Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/CLS2-981 Display EYB activity on Company Overview page #7396

Merged

Conversation

swenban
Copy link
Contributor

@swenban swenban commented Dec 12, 2024

Description of change

This PR displays EYB activity on the relevant company overview page.

  • EYB leads are displayed as recent activity cards and show their value (high/low/unknown) in the summary.
  • Investment projects that have been created from an EYB lead have an updated summary that displays 'from EYB Lead' at the end.

Test instructions

EYB leads:

  • Add an EYB lead to your environment

  • To populate your database with EYB Lead instances:

    • In Docker, go to the api container
    • Go to the 'Exec' tab
    • Run the following commands
python manage.py shell
from datahub.investment_lead.test.factories import EYBLeadFactory
EYBLeadFactory.create_batch(1)
  • Ensure the EYB Lead is linked to a company
  • Visit the company overview page for that company
  • A card displaying the EYB lead should be displayed under 'Recent activity'
  • The card should have the 'EYB' tag
  • In Django Admin update the 'Is high value' field to yes/no/unknown and check that the EYB activity card summary updates accordingly ('yes' = 'A high-value', 'no' = 'A low-value', 'unknown' = 'An unknown-value')
Screenshot 2024-12-18 at 09 53 05 Screenshot 2024-12-18 at 09 53 40 Screenshot 2024-12-18 at 09 54 22

Linked investment projects:

  • Visit the details page for your EYB Lead
  • Click on the 'Add investment project' button
  • Complete the process of creating an investment project. This project will be linked to your EYB lead
  • Return to the company overview page
  • A card displaying the investment project should be displayed under 'Recent activity'
  • Check that the end of the summary text includes 'from EYB lead'
  • Any investment projects not linked to an EYB lead should not display this additional text
Screenshot 2024-12-18 at 09 42 32

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

Copy link

cypress bot commented Dec 12, 2024

data-hub-frontend    Run #58136

Run Properties:  status check passed Passed #58136  •  git commit 3232868c71: Display linked company name if it exists
Project data-hub-frontend
Branch Review feature/CLS2-981-display-eyb-activity-info-on-company-overview-page
Run status status check passed Passed #58136
Run duration 01m 37s
Commit git commit 3232868c71: Display linked company name if it exists
Committer Sophie Wenban
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 15
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.55%. Comparing base (13be91e) to head (3232868).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...yOverview/TableCards/ActivityCards/transformers.js 96.15% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7396   +/-   ##
=======================================
  Coverage   88.54%   88.55%           
=======================================
  Files        1159     1159           
  Lines       18039    18063   +24     
  Branches     5114     5121    +7     
=======================================
+ Hits        15972    15995   +23     
- Misses       2067     2068    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swenban swenban force-pushed the feature/CLS2-981-display-eyb-activity-info-on-company-overview-page branch from 5f9a66c to c5083ba Compare December 16, 2024 15:08
@swenban swenban force-pushed the feature/CLS2-981-display-eyb-activity-info-on-company-overview-page branch from 210a86a to 3232868 Compare December 18, 2024 09:24
@swenban swenban marked this pull request as ready for review December 18, 2024 10:45
@swenban swenban requested a review from a team as a code owner December 18, 2024 10:45
@swenban swenban merged commit 3664d8e into main Dec 18, 2024
16 checks passed
@swenban swenban deleted the feature/CLS2-981-display-eyb-activity-info-on-company-overview-page branch December 18, 2024 11:32
chopkinsmade pushed a commit that referenced this pull request Dec 18, 2024
…ay-eyb-activity-info-on-company-overview-page

generated from commit 3664d8e
@swenban swenban self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants